Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 187603010: gracefully degrade with response to client if fail to access client specified dart sdk (Closed)

Created:
6 years, 9 months ago by danrubel
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

gracefully degrade with response to client if fail to access client specified dart sdk + return response if client specifies inaccessible sdk + cleanup JSON encode/decode references + cleanup channel close processing R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=33355

Patch Set 1 #

Total comments: 2

Patch Set 2 : add ask access error code #

Patch Set 3 : take 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M pkg/analysis_server/lib/src/analysis_manager.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 1 1 chunk +9 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 3 chunks +1 line, -6 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
6 years, 9 months ago (2014-03-05 22:40:35 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/187603010/diff/1/pkg/analysis_server/lib/src/domain_server.dart File pkg/analysis_server/lib/src/domain_server.dart (right): https://codereview.chromium.org/187603010/diff/1/pkg/analysis_server/lib/src/domain_server.dart#newcode116 pkg/analysis_server/lib/src/domain_server.dart:116: // TODO what error code should be returned ...
6 years, 9 months ago (2014-03-05 22:48:08 UTC) #2
danrubel
https://codereview.chromium.org/187603010/diff/1/pkg/analysis_server/lib/src/domain_server.dart File pkg/analysis_server/lib/src/domain_server.dart (right): https://codereview.chromium.org/187603010/diff/1/pkg/analysis_server/lib/src/domain_server.dart#newcode116 pkg/analysis_server/lib/src/domain_server.dart:116: // TODO what error code should be returned here? ...
6 years, 9 months ago (2014-03-05 23:27:13 UTC) #3
danrubel
6 years, 9 months ago (2014-03-05 23:30:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r33355 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698