Issue 187503002: 1. Restructure reusable handles to make individual Scopes for each handle type

Issue 187503002: 1. Restructure reusable handles to make individual Scopes for each handle type (Closed)

Created:
6 years, 9 months ago by siva

Modified:
6 years, 9 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

1. Restructure reusable handles to make individual Scopes for each handle type 2. Add a convenience macro to make use of reusable handle scopes easier R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33471

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Patch Set 7 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+218 lines, -209 lines)			Patch
M	runtime/vm/base_isolate.h	View	1 2 3 4 5	3 chunks	+0 lines, -12 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2 3 4 5	8 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1 2 3 4 5 6	5 chunks	+42 lines, -16 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2 3 4 5 6	3 chunks	+10 lines, -3 lines	0 comments	Download
M	runtime/vm/longjump.cc	View	1 2 3 4 5 6	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4 5	2 chunks	+10 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4 5	15 chunks	+66 lines, -47 lines	0 comments	Download
M	runtime/vm/reusable_handles.h	View	1 2 3 4 5 6	1 chunk	+67 lines, -111 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

-Ivan https://codereview.chromium.org/187503002/diff/60001/runtime/vm/base_isolate.h File runtime/vm/base_isolate.h (right): https://codereview.chromium.org/187503002/diff/60001/runtime/vm/base_isolate.h#newcode14 runtime/vm/base_isolate.h:14: #define REUSABLE_HANDLE_LIST(V) \ Should these really be on ...

6 years, 9 months ago (2014-03-06 18:29:36 UTC) #2

siva

reworked the cl PTAL https://codereview.chromium.org/187503002/diff/60001/runtime/vm/base_isolate.h File runtime/vm/base_isolate.h (right): https://codereview.chromium.org/187503002/diff/60001/runtime/vm/base_isolate.h#newcode14 runtime/vm/base_isolate.h:14: #define REUSABLE_HANDLE_LIST(V) \ Moved it ...

6 years, 9 months ago (2014-03-07 19:42:32 UTC) #3

siva

6 years, 9 months ago (2014-03-08 00:26:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #7 manually as r33471 (presubmit successful).

Expand Messages | Collapse Messages