Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18749002: Use typedefs in lib. (Closed)

Created:
7 years, 5 months ago by Johnni Winther
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use typedefs in lib. BUG=http://dartbug.com/7733 R=karlklose@google.com, lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=24909

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebased #

Patch Set 3 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -95 lines) Patch
M sdk/lib/_collection_dev/iterable.dart View 1 11 chunks +11 lines, -33 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M sdk/lib/async/stream.dart View 1 15 chunks +15 lines, -45 lines 0 comments Download
M sdk/lib/async/stream_impl.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/async/stream_pipe.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Johnni Winther
https://codereview.chromium.org/18749002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/18749002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1547 sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1547: if (type.containsTypeVariables || This is a temporary fix for ...
7 years, 5 months ago (2013-07-05 06:38:26 UTC) #1
karlklose
https://codereview.chromium.org/18749002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/18749002/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1547 sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1547: if (type.containsTypeVariables || Change that to bailout for function ...
7 years, 5 months ago (2013-07-08 08:37:30 UTC) #2
Lasse Reichstein Nielsen
lgtm
7 years, 5 months ago (2013-07-09 08:01:31 UTC) #3
karlklose
LGTM.
7 years, 5 months ago (2013-07-11 10:32:55 UTC) #4
Johnni Winther
7 years, 5 months ago (2013-07-11 10:34:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r24909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698