Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1874623004: Don't include Cache-Control header for served assets. (Closed)

Created:
4 years, 8 months ago by Bob Nystrom
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't include Cache-Control header for served assets. This was confusing browsers which ignore the ETag for XHRs and would simply use the local cache for an asset even if it had changed on the server. R=sigmund@google.com Committed: https://github.com/dart-lang/pub/commit/5257a0630a8db4f1ae339910eef5080ce384afc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M lib/src/barback/barback_server.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Bob Nystrom
4 years, 8 months ago (2016-04-08 23:32:17 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 8 months ago (2016-04-08 23:34:59 UTC) #5
Bob Nystrom
4 years, 8 months ago (2016-04-08 23:36:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5257a0630a8db4f1ae339910eef5080ce384afc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698