Issue 187443004: Avoid unnecessary future in the HTTP stack, after latest cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187443004: Avoid unnecessary future in the HTTP stack, after latest cleanup. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen

Modified:
6 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid unnecessary future in the HTTP stack, after latest cleanup. Also move _writeHeaders into _HttpOutgoing, so all outgoing logic is located there. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33326

Patch Set 1 #

Total comments: 2

Patch Set 2 : Doc fix. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -172 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View	1	13 chunks	+160 lines, -171 lines	0 comments	Download
	M	tests/standalone/io/http_head_test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/187443004/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/187443004/diff/1/sdk/lib/io/http_impl.dart#newcode898 sdk/lib/io/http_impl.dart:898: // immidiately.. immidiately.. .> immediately.

6 years, 9 months ago (2014-03-05 11:30:29 UTC) #2

Anders Johnsen

https://codereview.chromium.org/187443004/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/187443004/diff/1/sdk/lib/io/http_impl.dart#newcode898 sdk/lib/io/http_impl.dart:898: // immidiately.. On 2014/03/05 11:30:29, Søren Gjesse wrote: > ...

6 years, 9 months ago (2014-03-05 11:42:53 UTC) #3

Anders Johnsen

6 years, 9 months ago (2014-03-05 11:43:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r33326 (presubmit successful).

Expand Messages | Collapse Messages