pkg/unittest: much cleaner support for arbitrary args in expectAsync functions

pkg/unittest: much cleaner support for arbitrary args in expectAsync functions

remove calls to deprecated methods in tests
whitespace cleanup

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33346

[kevmoo, 2014-03-05 03:16:58]

It's nice sitting next to Gilad for a day :-)

[Siggi Cherem (dart-lang), 2014-03-05 19:09:17]

lgtm

https://codereview.chromium.org/187323003/diff/40001/pkg/unittest/test/unitte...
File pkg/unittest/test/unittest_expect_async_args_test.dart (right):

https://codereview.chromium.org/187323003/diff/40001/pkg/unittest/test/unitte...
pkg/unittest/test/unittest_expect_async_args_test.dart:24:
expect(expectAsync(_getArgs)(1, 2, 3, 4, 5, 6), [1, 2, 3, 4, 5, 6]);
what happens if you call it with 7 args (one more than you declared)?

[kevmoo, 2014-03-05 21:41:26]

https://codereview.chromium.org/187323003/diff/40001/pkg/unittest/test/unitte...
File pkg/unittest/test/unittest_expect_async_args_test.dart (right):

https://codereview.chromium.org/187323003/diff/40001/pkg/unittest/test/unitte...
pkg/unittest/test/unittest_expect_async_args_test.dart:24:
expect(expectAsync(_getArgs)(1, 2, 3, 4, 5, 6), [1, 2, 3, 4, 5, 6]);
On 2014/03/05 19:09:18, Siggi Cherem (dart-lang) wrote:
> what happens if you call it with 7 args (one more than you declared)?

I added a test for too many args passed and providing a method with too many
args.

Both fail.

[kevmoo, 2014-03-05 21:41:51]

Committed patchset #4 manually as r33346 (presubmit successful).

[Siggi Cherem (dart-lang), 2014-03-05 21:44:11]

lgtm, thankx