Add order to DartType.

Add order to DartType.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27098

[karlklose, 2013-07-12 14:57:17]

Is this only a debug tool? In this case, comparing the string representation
should be enough.

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1265: *   - interface
and typedef of the same element are ordered type arguments
'are ordered by the order of their type arguments'.

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1266: * * function
types, internally ordered by
remove 'internally'?

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1291: if (a.kind ==
TypeKind.INTERFACE ||
You could extract this test as a helper. This condition is what you refer to as
'defined by a declaration', isn't it? Giving it a name would also make the
comment easier to understand.

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1300: if (b.kind ==
TypeKind.TYPE_VARIABLE) {
return b.kind == TypeKind.TYPE_VARIABLE ? 0 : 1;

How can they have the same position but be different?

[Johnni Winther, 2013-07-12 17:50:25]

On 2013/07/12 14:57:17, karlklose wrote:
> Is this only a debug tool? In this case, comparing the string representation
> should be enough.
> 
The intention is to use this ordering when generating code based on types, for
instance the function type predicates and signatures.

[Johnni Winther, 2013-08-28 08:57:18]

Ping

[karlklose, 2013-08-28 09:24:01]

LGTM with the comments addressed.

[Johnni Winther, 2013-09-04 08:06:02]

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1265: *   - interface
and typedef of the same element are ordered type arguments
On 2013/07/12 14:57:17, karlklose wrote:
> 'are ordered by the order of their type arguments'.

Done.

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1266: * * function
types, internally ordered by
On 2013/07/12 14:57:17, karlklose wrote:
> remove 'internally'?

Done.

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1291: if (a.kind ==
TypeKind.INTERFACE ||
On 2013/07/12 14:57:17, karlklose wrote:
> You could extract this test as a helper. This condition is what you refer to
as
> 'defined by a declaration', isn't it? Giving it a name would also make the
> comment easier to understand.

Done.

https://codereview.chromium.org/18721005/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:1300: if (b.kind ==
TypeKind.TYPE_VARIABLE) {
On 2013/07/12 14:57:17, karlklose wrote:
> return b.kind == TypeKind.TYPE_VARIABLE ? 0 : 1;
> 
> How can they have the same position but be different?

It shouldn't be possible.

[Johnni Winther, 2013-09-04 08:10:29]

Committed patchset #4 manually as r27098 (presubmit successful).