Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 1871763002: Fix the remaining strong mode warnings. (Closed)

Created:
4 years, 8 months ago by Bob Nystrom
Modified:
4 years, 8 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/stack_trace.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the remaining strong mode warnings. These ones require explicit casts to work around limitations in some SDK methods and expectAsync() in test. Ideally, we will change those APIs to be more soundly typed. Until then, this gets the package clean. R=nweiz@google.com Committed: https://github.com/dart-lang/stack_trace/commit/b528ff4a6b8cfcf53a67dde3b5722c863a0f2350

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/chain.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/chain/chain_test.dart View 2 chunks +4 lines, -1 line 1 comment Download
M test/chain/utils.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Bob Nystrom
4 years, 8 months ago (2016-04-07 22:55:40 UTC) #2
nweiz
https://codereview.chromium.org/1871763002/diff/1/test/chain/chain_test.dart File test/chain/chain_test.dart (right): https://codereview.chromium.org/1871763002/diff/1/test/chain/chain_test.dart#newcode54 test/chain/chain_test.dart:54: // TODO(rnystrom): Remove this cast if expectAsync() gets a ...
4 years, 8 months ago (2016-04-08 00:24:03 UTC) #3
nweiz
lgtm
4 years, 8 months ago (2016-04-08 00:24:48 UTC) #4
Bob Nystrom
4 years, 8 months ago (2016-04-08 00:25:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b528ff4a6b8cfcf53a67dde3b5722c863a0f2350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698