Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 187133004: When reading a full snapshot use the class id from the snapshot instead of generating a new one. Th… (Closed)

Created:
6 years, 9 months ago by siva
Modified:
6 years, 9 months ago
Reviewers:
regis, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

1. When reading a full snapshot use the class id from the snapshot instead of generating a new one. This ensures that assumptions made about the class id when generating a snapshot will still hold in the version that runs from a snapshot. 2. remove ObjectHistogram code as it is not used anymore and has been replaced by VM service. R=johnmccutchan@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=33340

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -336 lines) Patch
M runtime/vm/class_table.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/class_table.cc View 1 chunk +51 lines, -0 lines 1 comment Download
runtime/vm/heap.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/heap.cc View 1 4 chunks +0 lines, -10 lines 0 comments Download
M runtime/vm/heap_histogram.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
M runtime/vm/heap_histogram.cc View 1 1 chunk +0 lines, -213 lines 0 comments Download
M runtime/vm/isolate.h View 1 4 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/isolate.cc View 1 6 chunks +10 lines, -12 lines 0 comments Download
M runtime/vm/raw_object.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 3 chunks +0 lines, -15 lines 0 comments Download
M runtime/vm/snapshot.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
6 years, 9 months ago (2014-03-05 00:07:59 UTC) #1
regis
LGTM https://codereview.chromium.org/187133004/diff/20001/runtime/vm/class_table.cc File runtime/vm/class_table.cc (right): https://codereview.chromium.org/187133004/diff/20001/runtime/vm/class_table.cc#newcode141 runtime/vm/class_table.cc:141: // Some of the class table entries maybe ...
6 years, 9 months ago (2014-03-05 00:21:32 UTC) #2
Cutch
lgtm
6 years, 9 months ago (2014-03-05 14:41:34 UTC) #3
siva
6 years, 9 months ago (2014-03-05 19:24:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r33340 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698