Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 18704006: Removes checks for stack overflow from arm and mips simulators (Closed)

Created:
7 years, 5 months ago by zra
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removes checks for stack overflow from arm and mips simulators The checks were performed before runtime and native calls, but if we abort on an assertion failure there, then we never make it to the StackOverflow runtime call. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M runtime/vm/simulator_arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 5 months ago (2013-07-12 20:37:10 UTC) #1
regis
LGTM tricky :-)
7 years, 5 months ago (2013-07-12 22:23:56 UTC) #2
zra
7 years, 5 months ago (2013-07-12 23:06:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698