Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 187003003: fix printing in compact vm config (this broke after the changes to make stdout (Closed)

Created:
6 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, Anders Johnsen, dgrove
Visibility:
Public.

Description

fix printing in compact vm config (this broke after the changes to make stdout purely async (see dartbug.com/17269) R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=33312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/unittest/lib/compact_vm_config.dart View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
BTW - this is to workaround dartbug.com/17269
6 years, 9 months ago (2014-03-04 23:28:53 UTC) #1
Bob Nystrom
lgtm
6 years, 9 months ago (2014-03-04 23:29:33 UTC) #2
Siggi Cherem (dart-lang)
6 years, 9 months ago (2014-03-04 23:33:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33312 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698