Issue 18684004: Fix error in standalone/io/secure_socket_bad_data_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18684004: Fix error in standalone/io/secure_socket_bad_data_test. (Closed)

Created:
7 years, 5 months ago by Bill Hesse

Modified:
7 years, 5 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix error in standalone/io/secure_socket_bad_data_test. BUG= Committed: https://code.google.com/p/dart/source/detail?r=24767

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	tests/standalone/io/secure_socket_bad_data_test.dart	View		2 chunks	+9 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Committed patchset #1 manually as r24767 (presubmit successful).

7 years, 5 months ago (2013-07-04 10:15:59 UTC) #2

Anders Johnsen

lgtm https://codereview.chromium.org/18684004/diff/1/tests/standalone/io/secure_socket_bad_data_test.dart File tests/standalone/io/secure_socket_bad_data_test.dart (right): https://codereview.chromium.org/18684004/diff/1/tests/standalone/io/secure_socket_bad_data_test.dart#newcode92 tests/standalone/io/secure_socket_bad_data_test.dart:92: final completer = new Completer(); Make completer var ...

7 years, 5 months ago (2013-07-04 11:36:56 UTC) #3

Bill Hesse

7 years, 5 months ago (2013-07-04 11:41:36 UTC) #4

Message was sent while issue was closed.

On 2013/07/04 11:36:56, Anders Johnsen wrote:
> lgtm
> 
>
https://codereview.chromium.org/18684004/diff/1/tests/standalone/io/secure_so...
> File tests/standalone/io/secure_socket_bad_data_test.dart (right):
> 
>
https://codereview.chromium.org/18684004/diff/1/tests/standalone/io/secure_so...
> tests/standalone/io/secure_socket_bad_data_test.dart:92: final completer = new
> Completer();
> Make completer var and test for null?

That is a style issue.  I would prefer to use bool.  Otherwise, our values are
null and true.  That is weird to me.

Expand Messages | Collapse Messages