Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 186733004: Update expectations after landing Isolate.ping. (Closed)

Created:
6 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update expectations after landing Isolate.ping. Forgot to mark VM as failing due to not implementing it yet. Dart2js mirrors_used_test grows unexplainably. Committed: https://code.google.com/p/dart/source/detail?r=33373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/compiler/dart2js/dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
TBR
6 years, 9 months ago (2014-03-06 13:33:23 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r33373 (presubmit successful).
6 years, 9 months ago (2014-03-06 13:33:41 UTC) #2
karlklose
6 years, 9 months ago (2014-03-06 13:38:25 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698