Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 186623005: When running compile-all, clear code after compiling so that we do not out too much pressure on GC … (Closed)

Created:
6 years, 9 months ago by srdjan
Modified:
6 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

When running compile-all, clear code after compiling so that we do not out too much pressure on GC and measure the compilation instead. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M runtime/vm/compiler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
Note that this changes benchmark and will require regeneration of old benchmark data.
6 years, 9 months ago (2014-03-04 18:48:28 UTC) #1
siva
lgtm
6 years, 9 months ago (2014-03-04 18:54:11 UTC) #2
srdjan
6 years, 9 months ago (2014-03-04 19:52:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33294 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698