Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 18652002: Revert "Relax method override restrictions." (Closed)

Created:
7 years, 5 months ago by floitsch
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Relax method override restrictions." Revert "Update status file." This reverts commit r24731. This reverts commit r24732. Committed: https://code.google.com/p/dart/source/detail?r=24733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -130 lines) Patch
M runtime/vm/object.cc View 2 chunks +31 lines, -1 line 0 comments Download
M tests/corelib/corelib.status View 2 chunks +0 lines, -3 lines 0 comments Download
D tests/corelib/method_override2_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/corelib/method_override3_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib/method_override4_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/corelib/method_override_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
TBR. Forgot to run the full test-suite. Reverting for now.
7 years, 5 months ago (2013-07-03 16:39:38 UTC) #1
floitsch
7 years, 5 months ago (2013-07-03 16:39:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r24733 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698