Add Isolate ping functionality.

Add Isolate ping functionality.

Implement in dart2js.

R=ajohnsen@google.com, floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33371

[Søren Gjesse, 2014-03-04 10:20:35]

DBC

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:144: /**
Add WARNING.

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:167: void ping(SendPort responsePort, [int pingType
= PING_ALIVE]) {
No capability needed for this?

[Lasse Reichstein Nielsen, 2014-03-04 12:03:32]

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:144: /**
On 2014/03/04 10:20:35, Søren Gjesse wrote:
> Add WARNING.

Done.

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:167: void ping(SendPort responsePort, [int pingType
= PING_ALIVE]) {
No. You don't affect how the isolate runs and don't get any real information
about the isolate content, so it's considered harmless.

The same will be the case for the on-exit listener.

The uncaught error listener will probably need a capability, because the errors
may leak information.

[floitsch, 2014-03-04 12:12:50]

LGTM with comment (potentially flaky test).

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:154: *     The response should happen no sooner
than if sent with `PING_CONTROL`.
no later?

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:155: *     It may be sent earlier of the system has
a way to do so.
if the system

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:167: void ping(SendPort responsePort, [int pingType
= PING_ALIVE]) {
On 2014/03/04 10:20:35, Søren Gjesse wrote:
> No capability needed for this?

I think that ping is the minimal thing we can do. If you don't even want others
to do that, don't give the isolate-port away.

https://codereview.chromium.org/186403003/diff/1/tests/isolate/ping_pause_tes...
File tests/isolate/ping_pause_test.dart (right):

https://codereview.chromium.org/186403003/diff/1/tests/isolate/ping_pause_tes...
tests/isolate/ping_pause_test.dart:37: isolate.ping((new
ReceivePort()..first.then((_) {
I would prefer no cascading operator here.

https://codereview.chromium.org/186403003/diff/1/tests/isolate/ping_test.dart
File tests/isolate/ping_test.dart (right):

https://codereview.chromium.org/186403003/diff/1/tests/isolate/ping_test.dart...
tests/isolate/ping_test.dart:37: ..first.then((_) { result.add("alive");
})).sendPort,
You can't guarantee that "alive" will be before 4.
If the other isolate is fast enough it will have already handled the
echoPort.send(4).

Same for the the control one.

[Anders Johnsen, 2014-03-04 14:06:19]

lgtm, scary how simple it is on dart2js :)

https://codereview.chromium.org/186403003/diff/20001/sdk/lib/isolate/isolate....
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/186403003/diff/20001/sdk/lib/isolate/isolate....
sdk/lib/isolate/isolate.dart:153: * * `PING_ALIVE`: The the isolate responds as
soon as possible.
The the

https://codereview.chromium.org/186403003/diff/20001/sdk/lib/isolate/isolate....
sdk/lib/isolate/isolate.dart:155: *     It may be sent earlier of the system has
a way to do so.
of -> if

[Lasse Reichstein Nielsen, 2014-03-06 12:47:17]

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:154: *     The response should happen no sooner
than if sent with `PING_CONTROL`.
On 2014/03/04 12:12:51, floitsch wrote:
> no later?

Done.

https://codereview.chromium.org/186403003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:155: *     It may be sent earlier of the system has
a way to do so.
On 2014/03/04 12:12:51, floitsch wrote:
> if the system

Done.

https://codereview.chromium.org/186403003/diff/1/tests/isolate/ping_pause_tes...
File tests/isolate/ping_pause_test.dart (right):

https://codereview.chromium.org/186403003/diff/1/tests/isolate/ping_pause_tes...
tests/isolate/ping_pause_test.dart:37: isolate.ping((new
ReceivePort()..first.then((_) {
There goes the one-liner :)
Done.

https://codereview.chromium.org/186403003/diff/1/tests/isolate/ping_test.dart
File tests/isolate/ping_test.dart (right):

https://codereview.chromium.org/186403003/diff/1/tests/isolate/ping_test.dart...
tests/isolate/ping_test.dart:37: ..first.then((_) { result.add("alive");
})).sendPort,
Ack, true.
Rewritten to check that  
  4 <- 3 <- 2 <- 1 <- 0   (read "<-" as "comes before")
  "alive" <- 3
  "control" <- 2
  2 <- "event" <- 1

[Lasse Reichstein Nielsen, 2014-03-06 12:47:28]

Committed patchset #3 manually as r33371 (presubmit successful).