Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1862833002: Resolve symlinks when publishing from Git repos. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resolve symlinks when publishing from Git repos. "git ls-files" doesn't natively resolve symlinks, so this adds some logic to do so manually. This brings the behavior of uploading from a Git repo in line with non-Git uploading. We still don't have a multipart parser in Dart, so we unfortunately have to way of writing automated tests that the tarballs are created as expected. I did verify this behavior locally, though. Closes #1400 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/be164a815c5ffbc0bc79c80a904f6fbe17339a38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M lib/src/package.dart View 2 chunks +40 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 8 months ago (2016-04-05 22:34:41 UTC) #1
Bob Nystrom
lgtm
4 years, 8 months ago (2016-04-05 23:20:35 UTC) #2
nweiz
4 years, 8 months ago (2016-04-05 23:50:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be164a815c5ffbc0bc79c80a904f6fbe17339a38 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698