Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186153005: New analzyer snapshot. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

New analzyer snapshot. Replace isInstanceOf() with a predicate. Tweaks for other packages. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33304

Patch Set 1 #

Total comments: 5

Patch Set 2 : Use meaningful name instead of '_' in predicate. #

Patch Set 3 : Use meaningful name instead of '_' in predicate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4003 lines, -3413 lines) Patch
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/visitor/NodeLocatorTest.java View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/ResolutionVerifier.java View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_engine.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
A editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java View 1 2 1 chunk +223 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 1 2 7 chunks +8 lines, -3 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/SemanticProcessor.java View 1 2 3 chunks +26 lines, -4 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/AstFactory.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/bin/analyzer.dart View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 1 2 46 chunks +600 lines, -598 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 2 12 chunks +22 lines, -22 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 2 24 chunks +39 lines, -39 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 2 67 chunks +477 lines, -100 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 1 2 22 chunks +29 lines, -29 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 2 1 chunk +0 lines, -73 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_engine.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 2 280 chunks +1101 lines, -1101 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 2 372 chunks +1054 lines, -992 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 1 2 14 chunks +35 lines, -37 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 2 74 chunks +234 lines, -228 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 31 chunks +107 lines, -66 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M pkg/code_transformers/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/observe/lib/transformer.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/observe/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/build/import_inliner.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/build/script_compactor.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years, 9 months ago (2014-03-04 21:02:03 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/186153005/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java File editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java (right): https://codereview.chromium.org/186153005/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java#newcode189 editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java:189: identifier("_"), As I said before, it would be ...
6 years, 9 months ago (2014-03-04 21:17:46 UTC) #2
scheglov
https://codereview.chromium.org/186153005/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java File editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java (right): https://codereview.chromium.org/186153005/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java#newcode189 editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineInstanceOfProcessor.java:189: identifier("_"), On 2014/03/04 21:17:47, Brian Wilkerson wrote: > As ...
6 years, 9 months ago (2014-03-04 21:50:15 UTC) #3
scheglov
Committed patchset #3 manually as r33304 (presubmit successful).
6 years, 9 months ago (2014-03-04 21:51:02 UTC) #4
Jennifer Messerly
6 years, 9 months ago (2014-03-04 22:15:35 UTC) #5
Message was sent while issue was closed. 
awesome! LGTM

Powered by Google App Engine
This is Rietveld 408576698