Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18612009: New analyzer_experimental snapshot. (Closed)

Created:
7 years, 5 months ago by scheglov
Modified:
7 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer_experimental snapshot. The biggest change is in formatting long list literals. It looks now better and also does not turn Editor into text mode for couple files. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6333 lines, -1306 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 1 chunk +1 line, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/ToFormattedSourceVisitor.java View 1 chunk +11 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 13 chunks +120 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/constant.dart View 16 chunks +64 lines, -64 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 3 chunks +64 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 7 chunks +220 lines, -120 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/error.dart View 110 chunks +572 lines, -235 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/html.dart View 4 chunks +44 lines, -7 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 19 chunks +253 lines, -41 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 55 chunks +533 lines, -130 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/scanner.dart View 4 chunks +143 lines, -4 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/ast_test.dart View 21 chunks +157 lines, -39 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/element_test.dart View 8 chunks +38 lines, -9 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/parser_test.dart View 44 chunks +244 lines, -49 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 196 chunks +3749 lines, -561 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/scanner_test.dart View 4 chunks +85 lines, -14 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/test_support.dart View 2 chunks +24 lines, -4 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 4 chunks +11 lines, -7 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 5 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 5 months ago (2013-07-10 20:14:18 UTC) #1
Brian Wilkerson
LGTM
7 years, 5 months ago (2013-07-10 23:45:59 UTC) #2
scheglov
7 years, 5 months ago (2013-07-11 01:52:05 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r24903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698