Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 1860843002: Get rid of some unnecessary logic in terseChain(). (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of some unnecessary logic in terseChain(). We no longer generate a file called runInIsolate.dart, so there's no reason to fold it out of our stack chains. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/968bfbb57fde5164fa79a2bfd5062a9786d5243c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M lib/src/utils.dart View 1 chunk +3 lines, -15 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 8 months ago (2016-04-05 00:10:08 UTC) #1
kevmoo
lgtm
4 years, 8 months ago (2016-04-05 02:38:57 UTC) #2
nweiz
4 years, 8 months ago (2016-04-05 21:31:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
968bfbb57fde5164fa79a2bfd5062a9786d5243c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698