Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 18577002: Reapply expanding overloaded functions into separate functions. (Closed)

Created:
7 years, 5 months ago by Emily Fortuna
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply expanding overloaded functions into separate functions. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=24709

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+679 lines, -233 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 14 chunks +84 lines, -35 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 12 chunks +60 lines, -37 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 4 chunks +16 lines, -3 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 4 chunks +14 lines, -16 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 3 chunks +72 lines, -2 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 3 chunks +45 lines, -91 lines 0 comments Download
M tests/html/audiocontext_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/html/canvasrenderingcontext2d_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/html/form_data_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/indexeddb_1_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/indexeddb_3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/indexeddb_4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/indexeddb_5_test.dart View 5 chunks +18 lines, -18 lines 0 comments Download
M tests/html/interactive_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/url_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/webgl_1_test.dart View 2 chunks +35 lines, -0 lines 0 comments Download
M tools/dom/dom.json View 1 14 chunks +50 lines, -3 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 2 chunks +1 line, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 3 chunks +75 lines, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 5 chunks +81 lines, -5 lines 0 comments Download
M tools/dom/scripts/logging.conf View 2 chunks +7 lines, -1 line 0 comments Download
M tools/dom/scripts/monitored.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 3 chunks +8 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_URL.darttemplate View 1 chunk +10 lines, -1 line 0 comments Download
A tools/dom/templates/html/impl/impl_AudioNode.darttemplate View 1 chunk +16 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate View 1 chunk +25 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Navigator.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
The first patch set is this previously committed CL: https://codereview.chromium.org/16494002/ that got reverted. The second ...
7 years, 5 months ago (2013-07-02 22:27:30 UTC) #1
Jennifer Messerly
lgtm.
7 years, 5 months ago (2013-07-02 22:29:59 UTC) #2
Emily Fortuna
7 years, 5 months ago (2013-07-02 22:33:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r24709 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698