Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18563006: More tests updated to optimize code (Part 2). (Closed)

Created:
7 years, 5 months ago by srdjan
Modified:
7 years, 5 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, zra, regis
Visibility:
Public.

Description

More tests updated to optimize code (Part 2). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=24927

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -122 lines) Patch
M tests/language/double_modulo_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/equality_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/language/exception_in_increment_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/fast_method_extraction_test.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M tests/language/identical_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/if_conversion_vm_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/language/inline_add_constants_to_initial_env_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/inline_closure_with_constant_arguments_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/inline_effect_context_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/language/inline_getter_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/language/inline_test_context_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/language/inline_value_context_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/language/instance_incr_deopt_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/language/instanceof4_test.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/language/issue11087_vm_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/language/issue7513_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/issue7525_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/language.status View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tests/language/large_implicit_getter_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/load_to_load_forwarding_vm_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/many_generic_instanceof_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/many_overridden_no_such_method_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/megamorphic_no_such_method_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/language/mint_arithmetic_test.dart View 6 chunks +6 lines, -5 lines 0 comments Download
M tests/language/mint_compares_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/modulo_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/no_such_method3_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/language/no_such_method_dispatcher_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/language/null_hashcode_optimized_vm_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/number_identity2_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/number_identity_test.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/optimization_test.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M tests/language/optimize_redundant_array_load_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/language/optimized_constant_array_string_access_test.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M tests/language/optimized_hoisting_checked_mode_assert_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/optimized_lists_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/optimized_setter_test.dart View 9 chunks +11 lines, -10 lines 0 comments Download
M tests/language/optimized_string_charat_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M tests/language/optimized_string_charcodeat_test.dart View 6 chunks +6 lines, -5 lines 0 comments Download
M tests/language/range_analysis_test.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M tests/language/strict_equal_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/string_intrinsics_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/try_catch2_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/try_catch3_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/try_catch4_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/try_catch5_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/try_catch_optimized1_test.dart View 2 chunks +15 lines, -14 lines 0 comments Download
M tests/language/try_catch_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/language/type_propagation_assert_assignable_test.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
srdjan
7 years, 5 months ago (2013-07-11 18:25:30 UTC) #1
srdjan
Added also failures on SIMARM & SIMMIPS
7 years, 5 months ago (2013-07-11 18:33:46 UTC) #2
siva
lgtm https://codereview.chromium.org/18563006/diff/3001/tests/language/number_identity_test.dart File tests/language/number_identity_test.dart (right): https://codereview.chromium.org/18563006/diff/3001/tests/language/number_identity_test.dart#newcode10 tests/language/number_identity_test.dart:10: for (int i = 0; i < 10; ...
7 years, 5 months ago (2013-07-11 20:08:20 UTC) #3
zra
dbc https://codereview.chromium.org/18563006/diff/3001/tests/language/number_identity_test.dart File tests/language/number_identity_test.dart (right): https://codereview.chromium.org/18563006/diff/3001/tests/language/number_identity_test.dart#newcode10 tests/language/number_identity_test.dart:10: for (int i = 0; i < 10; ...
7 years, 5 months ago (2013-07-11 20:11:28 UTC) #4
srdjan
https://codereview.chromium.org/18563006/diff/3001/tests/language/number_identity_test.dart File tests/language/number_identity_test.dart (right): https://codereview.chromium.org/18563006/diff/3001/tests/language/number_identity_test.dart#newcode10 tests/language/number_identity_test.dart:10: for (int i = 0; i < 10; i++) ...
7 years, 5 months ago (2013-07-11 20:12:46 UTC) #5
srdjan
Committed patchset #3 manually as r24927 (presubmit successful).
7 years, 5 months ago (2013-07-11 20:13:02 UTC) #6
srdjan
7 years, 5 months ago (2013-07-11 20:15:32 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/18563006/diff/3001/tests/language/optimized_s...
File tests/language/optimized_setter_test.dart (right):

https://codereview.chromium.org/18563006/diff/3001/tests/language/optimized_s...
tests/language/optimized_setter_test.dart:147: for (int i = 0; i< 20; i++) {}
On 2013/07/11 20:11:28, zra wrote:
> What's the point of this loop?

Don't know. Will remove it.

Powered by Google App Engine
This is Rietveld 408576698