Archive dartium on android builds

Archive dartium on android builds

Set internal acls for now.

R=kustermann@google.com, whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33368

[Bill Hesse, 2014-03-06 09:18:22]

lgtm

[kustermann, 2014-03-06 09:20:35]

lgtm with comments

Note that we've actually careted tools/bots/steps_clank.py for this, you might
want to remove it, if tools/bots/dartium_android.py.

https://codereview.chromium.org/185583003/diff/1/tools/bots/bot_utils.py
File tools/bots/bot_utils.py (right):

https://codereview.chromium.org/185583003/diff/1/tools/bots/bot_utils.py#newc...
tools/bots/bot_utils.py:91: self.bucket = 'gs://dart-archive'
I'd make a named parameter to the constructor to specify the bucket, make
'gs://dart-archive' the default. Then we could have an internal
'gs://dart-archive-internal' bucket.

Maybe making a GCSInternalNamer subclass of GCSNamer would be better.

https://codereview.chromium.org/185583003/diff/1/tools/bots/bot_utils.py#newc...
tools/bots/bot_utils.py:153: return 'Chrome.apk'
I'd prefer if we can differentiate between release/debug, arm/arm64. Just do it
like we do for normal dartium, i.e.:

.../dartium/dartium-android-arm-release.apk
.../dartium/content_shell-android-arm-debug.apk

I.e. use the functionality in "dartium_variant_zipfilename"

https://codereview.chromium.org/185583003/diff/1/tools/bots/dartium_android.py
File tools/bots/dartium_android.py (right):

https://codereview.chromium.org/185583003/diff/1/tools/bots/dartium_android.p...
tools/bots/dartium_android.py:26: APK_LOCATION = 'apks/Chrome.apk'
Please also archive ContentShell.apk (I think it should be there).

https://codereview.chromium.org/185583003/diff/1/tools/bots/dartium_android.p...
tools/bots/dartium_android.py:54: die("No build products directory given.")
Where is "die" comming from? Maybe you need to do bot_utils.die() [I don't know
where "die" is]

[ricow1, 2014-03-06 11:49:04]

Added arch and mode to file name
Use internal bucket
Added content shell apk

https://codereview.chromium.org/185583003/diff/1/tools/bots/bot_utils.py
File tools/bots/bot_utils.py (right):

https://codereview.chromium.org/185583003/diff/1/tools/bots/bot_utils.py#newc...
tools/bots/bot_utils.py:91: self.bucket = 'gs://dart-archive'
On 2014/03/06 09:20:36, kustermann wrote:
> I'd make a named parameter to the constructor to specify the bucket, make
> 'gs://dart-archive' the default. Then we could have an internal
> 'gs://dart-archive-internal' bucket.
> 
> Maybe making a GCSInternalNamer subclass of GCSNamer would be better.
I am taking a optional parameter - internal - to swithc on

https://codereview.chromium.org/185583003/diff/1/tools/bots/bot_utils.py#newc...
tools/bots/bot_utils.py:153: return 'Chrome.apk'
On 2014/03/06 09:20:36, kustermann wrote:
> I'd prefer if we can differentiate between release/debug, arm/arm64. Just do
it
> like we do for normal dartium, i.e.:
> 
> .../dartium/dartium-android-arm-release.apk
> .../dartium/content_shell-android-arm-debug.apk
> 
> I.e. use the functionality in "dartium_variant_zipfilename"

valid point, I will add that

https://codereview.chromium.org/185583003/diff/1/tools/bots/dartium_android.py
File tools/bots/dartium_android.py (right):

https://codereview.chromium.org/185583003/diff/1/tools/bots/dartium_android.p...
tools/bots/dartium_android.py:26: APK_LOCATION = 'apks/Chrome.apk'
On 2014/03/06 09:20:36, kustermann wrote:
> Please also archive ContentShell.apk (I think it should be there).

We do have it - added

https://codereview.chromium.org/185583003/diff/1/tools/bots/dartium_android.p...
tools/bots/dartium_android.py:54: die("No build products directory given.")
On 2014/03/06 09:20:36, kustermann wrote:
> Where is "die" comming from? Maybe you need to do bot_utils.die() [I don't
know
> where "die" is]

Fixed up, I don't know when this landed

[Bill Hesse, 2014-03-06 12:13:48]

lgtm

[ricow1, 2014-03-06 12:14:44]

Committed patchset #2 manually as r33368 (presubmit successful).