Added a test to cover debugging step over.

Added a test to cover debugging step over.
Added a separate test to cover step in and out.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24706

[devoncarew, 2013-07-02 21:03:28]

This adds two tests to cover stepping. The first test (stepping_test.dart)
specifically covers the stepping regression from yesterday. I added another test
for step in/out before I saw that there is coverage for that in
basic_debugger_test.dart. This test does add some value in that it is more
specific, so I kept it in the CL.

[hausner, 2013-07-02 21:21:32]

LGTM.

While it's nice to separate the code that is being debugged from the debugging
script so it can be re-used, it makes the test harder to read and things are
more fragile. I'd prefer to keep the two pieces together.

[devoncarew, 2013-07-02 21:29:01]

On 2013/07/02 21:21:32, hausner wrote:
> LGTM.
> 
> While it's nice to separate the code that is being debugged from the debugging
> script so it can be re-used, it makes the test harder to read and things are
> more fragile. I'd prefer to keep the two pieces together.

I was having some trouble getting that regression to fire when the test and the
code under test were in the same file. The location of that first breakpoint is
significant for some reason. I'll make another run at combining them -

[devoncarew, 2013-07-02 21:37:00]

PTAL, updated to combine the test code code under test.

[hausner, 2013-07-02 21:39:21]

Knowing what the bug was, I don't understand how the location of the breakpoint
is significant.  Can you please try that again? The main thing is that a
breakpoint has to be set in the function, then after hitting that breakpoint,
one has to "step over" to the next breakpoint.

[hausner, 2013-07-02 21:48:14]

LGTM w/comment

https://codereview.chromium.org/18558005/diff/2002/tests/standalone/debugger/...
File tests/standalone/debugger/stepping_test.dart (right):

https://codereview.chromium.org/18558005/diff/2002/tests/standalone/debugger/...
tests/standalone/debugger/stepping_test.dart:8: if (RunScript(testScript))
return;
If this still gives you trouble to repro the bug we fixed yesterday, try to put
the print statements into a separate function.

void foo() {
  print('foo1');
  print('foo2');
  print('foo3');
}

main() {
  if (RunScript(testScript)) return;
  foo();
}

[devoncarew, 2013-07-02 22:12:42]

https://codereview.chromium.org/18558005/diff/2002/tests/standalone/debugger/...
File tests/standalone/debugger/stepping_test.dart (right):

https://codereview.chromium.org/18558005/diff/2002/tests/standalone/debugger/...
tests/standalone/debugger/stepping_test.dart:8: if (RunScript(testScript))
return;
On 2013/07/02 21:48:14, hausner wrote:
> If this still gives you trouble to repro the bug we fixed yesterday, try to
put
> the print statements into a separate function.

Ah, good idea. I was able to repro the issue having everything in one main()
method, but moving the test code into a separate method more closely matches the
repro case I had yesterday.

So, the current test does fail w/ yesterday's codebase, and passes w/ the fix to
debugger.cc.

[devoncarew, 2013-07-02 22:16:08]

Committed patchset #4 manually as r24706 (presubmit successful).