Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 18558002: Const constructor must have const super initializer (Closed)

Created:
7 years, 5 months ago by hausner
Modified:
7 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Const constructor must have const super initializer Compile time error if a const constructor calls a non-const super constructor (either explicitly or implicitly). R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=24704

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M runtime/vm/class_finalizer.cc View 1 1 chunk +1 line, -10 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
A tests/language/const_constructor_super_test.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 5 months ago (2013-07-02 17:47:42 UTC) #1
regis
LGTM
7 years, 5 months ago (2013-07-02 17:56:20 UTC) #2
hausner
Committed patchset #2 manually as r24704 (presubmit successful).
7 years, 5 months ago (2013-07-02 20:09:29 UTC) #3
hausner
7 years, 5 months ago (2013-07-02 20:13:51 UTC) #4
Message was sent while issue was closed.
Thank you. Had to change the test a bit to make the analyzer happy.

Powered by Google App Engine
This is Rietveld 408576698