Issue 185563013: Small changes in profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185563013: Small changes in profiler (Closed)

Created:
6 years, 9 months ago by Cutch

Modified:
6 years, 9 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Display sample count and refresh time. Fix some uninitialized variables. Don't send disassembly by default. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=33380

Patch Set 2 : #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -8 lines)			Patch
M	runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/isolate_profile.html	View	1	1 chunk	+13 lines, -7 lines	0 comments	Download
M	runtime/vm/profiler.cc	View		5 chunks	+19 lines, -0 lines	1 comment	Download
M	runtime/vm/service.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

lgtm w/ comment. https://codereview.chromium.org/185563013/diff/10001/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/185563013/diff/10001/runtime/vm/profiler.cc#newcode201 runtime/vm/profiler.cc:201: inclusive_tick_serial_(0), What is this used for?

6 years, 9 months ago (2014-03-06 16:36:41 UTC) #2

Cutch

6 years, 9 months ago (2014-03-06 16:49:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r33380 (presubmit successful).

Expand Messages | Collapse Messages

Issue 185563013: Small changes in profiler (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages