Issue 185553015: Minor VM performance improvements based on profiling.

Issue 185553015: Minor VM performance improvements based on profiling. (Closed)

Created:
6 years, 9 months ago by srdjan

Modified:
6 years, 9 months ago

Reviewers:
Anders Johnsen, siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Minor VM performance improvements based on profiling. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33333

Patch Set 8 : #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -43 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1 2 3 4 5 6 7	8 chunks	+16 lines, -13 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1 2 3 4 5 6 7	1 chunk	+12 lines, -11 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4 5 6 7	5 chunks	+21 lines, -18 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #8 manually as r33333 (presubmit successful).

6 years, 9 months ago (2014-03-05 17:42:45 UTC) #3

Anders Johnsen

Thanks Srdjan, I've seen this stuff in profiles as well! Want me to file bugs ...

6 years, 9 months ago (2014-03-05 19:56:05 UTC) #4

Ivan Posva

DBC -ip https://codereview.chromium.org/185553015/diff/100001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/185553015/diff/100001/runtime/vm/parser.cc#newcode384 runtime/vm/parser.cc:384: result = tokens_iterator_.CurrentLiteral(); Why don't you merge ...

6 years, 9 months ago (2014-03-06 10:32:45 UTC) #5

srdjan

6 years, 9 months ago (2014-03-06 17:52:01 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/185553015/diff/100001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/185553015/diff/100001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:384: result = tokens_iterator_.CurrentLiteral();
On 2014/03/06 10:32:45, Ivan Posva wrote:
> Why don't you merge these two lines?

Done in a following CL.

Expand Messages | Collapse Messages