Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 185543005: Make stream_timeout_test less likely to flake. (Closed)

Created:
6 years, 9 months ago by floitsch
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Make stream_timeout_test less likely to flake. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=33214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M tests/lib/async/stream_timeout_test.dart View 9 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
I gave the test more time (although 500ms already seemed plenty). Since we don't really ...
6 years, 9 months ago (2014-03-03 13:06:39 UTC) #1
Lasse Reichstein Nielsen
lgtm
6 years, 9 months ago (2014-03-03 13:16:15 UTC) #2
floitsch
Committed patchset #1 manually as r33214 (presubmit successful).
6 years, 9 months ago (2014-03-03 13:18:36 UTC) #3
ricow1
6 years, 9 months ago (2014-03-03 13:20:00 UTC) #4
Message was sent while issue was closed.
thanks

Powered by Google App Engine
This is Rietveld 408576698