Issue 185463004: Make _TestOptionSpecification take a named argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185463004: Make _TestOptionSpecification take a named argument. (Closed)

Created:
6 years, 9 months ago by ahe

Modified:
6 years, 9 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, kustermann, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make _TestOptionSpecification take a named argument. I want to refactor test_options.dart so that variable expansions, such as, "all" -> "debug,release" are generalized. So I want to add another named argument to _TestOptionSpecification in the next CL. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33207

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -41 lines)			Patch
	M	dart/tools/testing/dart/test_options.dart	View		10 chunks	+36 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM, but I always prefer named optional arguments to positional.

6 years, 9 months ago (2014-03-03 11:15:54 UTC) #2

ahe

6 years, 9 months ago (2014-03-03 11:46:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r33207 (presubmit successful).

Expand Messages | Collapse Messages