Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 185403018: Unroll 'synchronized {}' in java2dart. (Closed)

Created:
6 years, 9 months ago by scheglov
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Unroll 'synchronized {}' in java2dart. ...and corresponding 'analyzer' snapshot. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33318

Patch Set 1 #

Total comments: 2

Patch Set 2 : Include fix from Java #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1266 lines, -1402 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 5 chunks +25 lines, -11 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 40 chunks +1082 lines, -1177 lines 0 comments Download
M pkg/analyzer/lib/src/generated/index.dart View 16 chunks +69 lines, -107 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 6 chunks +9 lines, -40 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 3 chunks +16 lines, -22 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 4 chunks +55 lines, -37 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 9 months ago (2014-03-04 22:59:15 UTC) #1
Brian Wilkerson
Unfortunately, this introduces the bug whose fix you just reviewed, so we might want to ...
6 years, 9 months ago (2014-03-04 23:51:46 UTC) #2
scheglov
OK, will generate Dart version to include the fix. https://codereview.chromium.org/185403018/diff/1/pkg/code_transformers/pubspec.yaml File pkg/code_transformers/pubspec.yaml (right): https://codereview.chromium.org/185403018/diff/1/pkg/code_transformers/pubspec.yaml#newcode7 pkg/code_transformers/pubspec.yaml:7: ...
6 years, 9 months ago (2014-03-05 02:29:58 UTC) #3
scheglov
6 years, 9 months ago (2014-03-05 02:30:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r33318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698