Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 185403015: Mark deferred test as flaky in IE9. (Closed)

Created:
6 years, 9 months ago by sigurdm
Modified:
6 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark deferred test as flaky in IE9. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=33263

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/lib/lib.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sigurdm
6 years, 9 months ago (2014-03-04 10:04:27 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/185403015/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/185403015/diff/1/tests/lib/lib.status#newcode210 tests/lib/lib.status:210: mirrors/deferred/*: Pass, Fail, Timeout # http://dartbug.com/12635 I haven't ...
6 years, 9 months ago (2014-03-04 10:09:07 UTC) #2
sigurdm
Committed patchset #2 manually as r33263 (presubmit successful).
6 years, 9 months ago (2014-03-04 10:16:39 UTC) #3
sigurdm
6 years, 9 months ago (2014-03-04 10:17:12 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/185403015/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/185403015/diff/1/tests/lib/lib.status#newcode210
tests/lib/lib.status:210: mirrors/deferred/*: Pass, Fail, Timeout #
http://dartbug.com/12635
On 2014/03/04 10:09:07, floitsch wrote:
> I haven't seen "Timeout" yet.
> Unless you have seen it, let's keep it out for now.

Done.

Powered by Google App Engine
This is Rietveld 408576698