Issue 18540002: Add fillRange to typed ungrowable lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18540002: Add fillRange to typed ungrowable lists. (Closed)

Created:
7 years, 5 months ago by zarah

Modified:
7 years, 5 months ago

Reviewers:
floitsch, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add fillRange to typed ungrowable lists. BUG=http://dartbug.com/11621 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=24689

Patch Set 1 #

Patch Set 2 : Removed new lines. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -9 lines)			Patch
	M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View		9 chunks	+9 lines, -9 lines	0 comments	Download
	A	tests/corelib/list_ungrowable_fillRange_test.dart	View	1	1 chunk	+127 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zarah

Committed patchset #2 manually as r24689 (presubmit successful).

7 years, 5 months ago (2013-07-02 15:15:12 UTC) #3

sra1

7 years, 5 months ago (2013-07-02 18:54:49 UTC) #4

Message was sent while issue was closed.

tests/corelib/ is the wrong place for this test, since dart:typed_data is a
separate lib to dart:corelib. 

There are already typed_data tests under:

  tests/html/
  tests/standalone/
  tests/lib/typed_data/

tests/standalone/ is also wrong since we want test coverage of browsers, each
which has a different implementation of typed data.

Depending on where the test is moved, it needs to suppress IE9 which does not
have typed data types.

* if you move the code to tests/html/, rewrite it to use unittest and to import
dart:html so you can test Platform.supportsTypedData to see if the browser that
the code is running in supports typed_data.  See the other examples in that
directory.

* if you move it to tests/lib/typed_data/, be sure to mark ie9 as failing in
tests/lib/lib.status

Expand Messages | Collapse Messages