Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 18532010: Fix for parsing top-level variable named 'get' or 'set'. (Closed)

Created:
7 years, 5 months ago by scheglov
Modified:
7 years, 5 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Fix for parsing top-level variable named 'get' or 'set'. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/SimpleParserTest.java View 1 chunk +18 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 5 months ago (2013-07-09 02:52:57 UTC) #1
Brian Wilkerson
LGTM
7 years, 5 months ago (2013-07-09 13:18:28 UTC) #2
jwren
On 2013/07/09 13:18:28, Brian Wilkerson wrote: > LGTM LGTM
7 years, 5 months ago (2013-07-09 16:39:48 UTC) #3
scheglov
7 years, 5 months ago (2013-07-09 16:44:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r24851 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698