Issue 18529009: Fix moveTo to not include null optional parameters in JSON message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18529009: Fix moveTo to not include null optional parameters in JSON message. (Closed)

Created:
7 years, 5 months ago by DrMarcII

Modified:
7 years, 5 months ago

Reviewers:
gram

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix moveTo to not include null optional parameters in JSON message. BUG=11685 R=gram@google.com Committed: https://code.google.com/p/dart/source/detail?r=25307

Patch Set 2 : Remove extra trailing newline #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	pkg/webdriver/lib/webdriver.dart	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gram

lgtm, just please remove trailing blank line. https://chromiumcodereview.appspot.com/18529009/diff/1/pkg/webdriver/lib/webdriver.dart File pkg/webdriver/lib/webdriver.dart (right): https://chromiumcodereview.appspot.com/18529009/diff/1/pkg/webdriver/lib/webdriver.dart#newcode1480 pkg/webdriver/lib/webdriver.dart:1480: Please remove ...

7 years, 5 months ago (2013-07-22 20:13:28 UTC) #1

DrMarcII

I don't have commit permissions, so will need you to commit this if it is ...

7 years, 5 months ago (2013-07-22 21:18:48 UTC) #3

gram

7 years, 5 months ago (2013-07-22 21:46:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r25307 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18529009: Fix moveTo to not include null optional parameters in JSON message. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove extra trailing newline #

Messages