Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1852513004: Make life a little more sparkly. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -15 lines) Patch
M lib/src/command_runner.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M lib/src/log.dart View 1 5 chunks +34 lines, -15 lines 0 comments Download
M lib/src/utils.dart View 1 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 8 months ago (2016-04-01 20:31:53 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1852513004/diff/1/lib/src/utils.dart File lib/src/utils.dart (right): https://codereview.chromium.org/1852513004/diff/1/lib/src/utils.dart#newcode295 lib/src/utils.dart:295: choose(List elements) => elements[random.nextInt(elements.length)]; Make this a generic ...
4 years, 8 months ago (2016-04-01 20:35:28 UTC) #2
nweiz
Code review changes
4 years, 8 months ago (2016-04-01 20:37:59 UTC) #3
nweiz
https://codereview.chromium.org/1852513004/diff/1/lib/src/utils.dart File lib/src/utils.dart (right): https://codereview.chromium.org/1852513004/diff/1/lib/src/utils.dart#newcode295 lib/src/utils.dart:295: choose(List elements) => elements[random.nextInt(elements.length)]; On 2016/04/01 20:35:27, Bob Nystrom ...
4 years, 8 months ago (2016-04-01 20:38:16 UTC) #4
nweiz
4 years, 8 months ago (2016-04-01 20:38:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
45645a860bd42cf26677e75bfc37063863bf1f8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698