Issue 185233016: Revert "Re-apply 'Fix fromEnvironment when called from isolates.'"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185233016: Revert "Re-apply 'Fix fromEnvironment when called from isolates.'" (Closed)

Created:
6 years, 9 months ago by Anders Johnsen

Modified:
6 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Re-apply 'Fix fromEnvironment when called from isolates.'" This reverts commit 1f2ddd083424a93dc0822c2ae86be971d5a97e21. BUG= Committed: https://code.google.com/p/dart/source/detail?r=33278

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -39 lines)			Patch
M	runtime/lib/bool.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/lib/integers.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/lib/string.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/corelib/bool_from_environment_default_value_test.dart	View	1 chunk	+1 line, -11 lines	0 comments	Download
M	tests/corelib/int_from_environment_default_value_test.dart	View	1 chunk	+1 line, -11 lines	0 comments	Download
M	tests/corelib/string_from_environment_default_value.dart	View	1 chunk	+1 line, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Anders Johnsen

Committed patchset #1 manually as r33278 (presubmit successful).

6 years, 9 months ago (2014-03-04 16:05:30 UTC) #1

Anders Johnsen

TBR - turned out to be non-trivial. Will ask the VM team for help on ...

6 years, 9 months ago (2014-03-04 16:05:59 UTC) #2

Message was sent while issue was closed.

lgtm