Issue 18523012: Report EXTENDS_NON_CLASS for 'extends dynamic'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18523012: Report EXTENDS_NON_CLASS for 'extends dynamic'. (Closed)

Created:
7 years, 5 months ago by scheglov

Modified:
7 years, 5 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Report EXTENDS_NON_CLASS for 'extends dynamic'. From the old Gilad message: Dynamic is not a class, so this is invalid as well, but for other reasons. In particular, there is no need for a special rule banning it. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24834

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -15 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java	View	6 chunks	+16 lines, -14 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

scheglov

7 years, 5 months ago (2013-07-09 02:25:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24834 (presubmit successful).