Issue 18500006: dart:io | Pass errors from multithreaded encryption back to Dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18500006: dart:io | Pass errors from multithreaded encryption back to Dart. (Closed)

Created:
7 years, 5 months ago by Bill Hesse

Modified:
7 years, 5 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

dart:io | Pass errors from multithreaded encryption back to Dart. BUG=dartbug.com/11383 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=24765

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -14 lines)			Patch
M	runtime/bin/net/ssl.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/secure_socket.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/secure_socket.cc	View		8 chunks	+23 lines, -11 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	sdk/lib/io/socket.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests/standalone/io/secure_socket_bad_data_test.dart	View	1	1 chunk	+154 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Bill Hesse

What should we do about the fact that bad data crashes (asserts) in debug mode? ...

7 years, 5 months ago (2013-07-04 08:12:07 UTC) #1

Anders Johnsen

LGTM, That's a good question. I'm puzzled why it would assert - asserts are for ...

7 years, 5 months ago (2013-07-04 08:21:06 UTC) #2

Bill Hesse

7 years, 5 months ago (2013-07-04 09:21:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r24765 (presubmit successful).