Add markdown to third_party/pkg

Add markdown to third_party/pkg

BUG=
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24807

[Andrei Mouravski, 2013-07-04 18:25:00]

How/when do these get updated in the future? Is there a README for using
third_party/pkg packages?

[Bob Nystrom, 2013-07-08 16:40:08]

I CC'd Peter because he's one of our gyp gurus.

https://codereview.chromium.org/18497012/diff/2001/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/18497012/diff/2001/pkg/pkg.gyp#newcode31
pkg/pkg.gyp:31: '<!@(["python", "../tools/list_pkg_directories.py",
"../third_party/pkg"])',
Long line.

https://codereview.chromium.org/18497012/diff/2001/pkg/pkg.gyp#newcode34
pkg/pkg.gyp:34: '<(SHARED_INTERMEDIATE_DIR)/packages.stamp',
Should probably use a different time stamp file for this since it's a separate
output. Maybe "third_party_packages.stamp".

https://codereview.chromium.org/18497012/diff/2001/pkg/pkg.gyp#newcode38
pkg/pkg.gyp:38: '--timestamp_file=<(SHARED_INTERMEDIATE_DIR)/packages.stamp',
And here.

https://codereview.chromium.org/18497012/diff/2001/third_party/pkg/markdown/....
File third_party/pkg/markdown/.gitignore (right):

https://codereview.chromium.org/18497012/diff/2001/third_party/pkg/markdown/....
third_party/pkg/markdown/.gitignore:5: out
How about moving this up a directory since every third party package will want
to ignore these?

https://codereview.chromium.org/18497012/diff/2001/tools/list_pkg_directories.py
File tools/list_pkg_directories.py (right):

https://codereview.chromium.org/18497012/diff/2001/tools/list_pkg_directories...
tools/list_pkg_directories.py:7: Used in pkg.gyp. Lists all of the directories
in the current directory
Update this since now it doesn't look in the current directory.

https://codereview.chromium.org/18497012/diff/2001/tools/list_pkg_directories...
tools/list_pkg_directories.py:19: os.path.join(argv[1], x)),
os.listdir(argv[1])))
Make a variable for argv[1] so it's clear what it's for.

[Emily Fortuna, 2013-07-08 17:36:30]

Andrei, in response to your question, we will have to manually update this
package into the dart repo when we see fit. It's not ideal, but this is only for
the specific case of testing on our buildbots. Everything else will use the
latest package. Dan, Bob, and I discussed and we determined this was the best
option given the circumstances.


PTAL

https://codereview.chromium.org/18497012/diff/2001/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/18497012/diff/2001/pkg/pkg.gyp#newcode31
pkg/pkg.gyp:31: '<!@(["python", "../tools/list_pkg_directories.py",
"../third_party/pkg"])',
On 2013/07/08 16:40:08, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/18497012/diff/2001/pkg/pkg.gyp#newcode34
pkg/pkg.gyp:34: '<(SHARED_INTERMEDIATE_DIR)/packages.stamp',
On 2013/07/08 16:40:08, Bob Nystrom wrote:
> Should probably use a different time stamp file for this since it's a separate
> output. Maybe "third_party_packages.stamp".

Done.

https://codereview.chromium.org/18497012/diff/2001/pkg/pkg.gyp#newcode38
pkg/pkg.gyp:38: '--timestamp_file=<(SHARED_INTERMEDIATE_DIR)/packages.stamp',
On 2013/07/08 16:40:08, Bob Nystrom wrote:
> And here.

Done.

https://codereview.chromium.org/18497012/diff/2001/third_party/pkg/markdown/....
File third_party/pkg/markdown/.gitignore (right):

https://codereview.chromium.org/18497012/diff/2001/third_party/pkg/markdown/....
third_party/pkg/markdown/.gitignore:5: out
On 2013/07/08 16:40:08, Bob Nystrom wrote:
> How about moving this up a directory since every third party package will want
> to ignore these?

Done.

https://codereview.chromium.org/18497012/diff/2001/tools/list_pkg_directories.py
File tools/list_pkg_directories.py (right):

https://codereview.chromium.org/18497012/diff/2001/tools/list_pkg_directories...
tools/list_pkg_directories.py:7: Used in pkg.gyp. Lists all of the directories
in the current directory
On 2013/07/08 16:40:08, Bob Nystrom wrote:
> Update this since now it doesn't look in the current directory.

Done. Looks like this was already a bit out of date since the usage was wrong.

https://codereview.chromium.org/18497012/diff/2001/tools/list_pkg_directories...
tools/list_pkg_directories.py:19: os.path.join(argv[1], x)),
os.listdir(argv[1])))
On 2013/07/08 16:40:08, Bob Nystrom wrote:
> Make a variable for argv[1] so it's clear what it's for.

Done.

https://codereview.chromium.org/18497012/diff/10001/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/18497012/diff/10001/pkg/pkg.gyp#newcode28
pkg/pkg.gyp:28: 'action_name': 'make_third_party_packages',
There may (I hope?) be a less verbose way to do this (adding a line around line
15?), but I wasn't having success doing so.

[Bob Nystrom, 2013-07-08 17:41:13]

LGTM

https://codereview.chromium.org/18497012/diff/10001/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/18497012/diff/10001/pkg/pkg.gyp#newcode28
pkg/pkg.gyp:28: 'action_name': 'make_third_party_packages',
On 2013/07/08 17:36:30, Emily Fortuna wrote:
> There may (I hope?) be a less verbose way to do this (adding a line around
line
> 15?), but I wasn't having success doing so. 

Yeah, Peter might be able to help here. Gyp is mostly dark magic to me.

[Emily Fortuna, 2013-07-08 17:43:52]

Committed patchset #2 manually as r24807 (presubmit successful).

[Andrei Mouravski, 2013-07-08 18:43:31]

On 2013/07/08 17:36:30, Emily Fortuna wrote:
> Andrei, in response to your question, we will have to manually update this
> package into the dart repo when we see fit. It's not ideal, but this is only
for
> the specific case of testing on our buildbots. Everything else will use the
> latest package. Dan, Bob, and I discussed and we determined this was the best
> option given the circumstances.

Emily, could you please document the process for manually updating this package?
I think an article on the wiki re: third_party would be an appropriate spot for
this, but it might be better to stick a README in third_party/

Really, I just want to know how I can update the package in third_part if I want
to.

[ahe, 2013-07-11 10:19:29]

https://codereview.chromium.org/18497012/diff/10001/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/18497012/diff/10001/pkg/pkg.gyp#newcode28
pkg/pkg.gyp:28: 'action_name': 'make_third_party_packages',
On 2013/07/08 17:41:13, Bob Nystrom wrote:
> On 2013/07/08 17:36:30, Emily Fortuna wrote:
> > There may (I hope?) be a less verbose way to do this (adding a line around
> line
> > 15?), but I wasn't having success doing so. 
> 
> Yeah, Peter might be able to help here. Gyp is mostly dark magic to me.

I've filed https://code.google.com/p/dart/issues/detail?id=11779 so I don't
forget.