Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 18496011: Clean up dart:io warnings/errors found by analyzer tests. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen
Modified:
7 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up dart:io warnings/errors found by analyzer tests. BUG=https://code.google.com/p/dart/issues/detail?id=11665 R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M sdk/lib/io/buffer_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/io/link.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/string_transformer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_fuzz_test.dart View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 5 months ago (2013-07-04 08:03:26 UTC) #1
Bill Hesse
LGTM. Kudos for improving code quality
7 years, 5 months ago (2013-07-04 08:16:05 UTC) #2
Anders Johnsen
7 years, 5 months ago (2013-07-04 08:17:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24764 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698