Issue 18496004: Retain type annotations for function subtyping in minified mode.

Issue 18496004: Retain type annotations for function subtyping in minified mode. (Closed)

Created:
7 years, 5 months ago by Johnni Winther

Modified:
7 years, 5 months ago

Reviewers:
Anton Muhin, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Retain type annotations for function subtyping in minified mode. BUG=dartbug.com/11467,dartbug.com/11468 R=antonm@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=24681

Patch Set 1 #

Total comments: 6

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -106 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View	2 chunks	+5 lines, -51 lines	6 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -44 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart File sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart (right): https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart#newcode357 sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart:357: var classNode = classElement.parseNode(compiler); This can also be NamedMixinApplication ...

7 years, 5 months ago (2013-07-02 11:33:51 UTC) #1

Anton Muhin

thanks a lot, just one question. https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart File sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart (left): https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart#oldcode199 sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart:199: processSuperclassTypeArguments(element, classNode.superclass); do ...

7 years, 5 months ago (2013-07-02 11:39:03 UTC) #2

Johnni Winther

https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart File sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart (left): https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart#oldcode199 sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart:199: processSuperclassTypeArguments(element, classNode.superclass); On 2013/07/02 11:39:03, Anton Muhin wrote: > ...

7 years, 5 months ago (2013-07-02 11:42:09 UTC) #3

Anton Muhin

lgtm https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart File sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart (left): https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart#oldcode199 sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart:199: processSuperclassTypeArguments(element, classNode.superclass); On 2013/07/02 11:42:10, Johnni Winther wrote: ...

7 years, 5 months ago (2013-07-02 11:43:01 UTC) #4

karlklose

LGTM. https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart File sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart (right): https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart#newcode357 sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart:357: var classNode = classElement.parseNode(compiler); Could we let them ...

7 years, 5 months ago (2013-07-02 12:16:39 UTC) #5

Johnni Winther

Committed patchset #1 manually as r24681 (presubmit successful).

7 years, 5 months ago (2013-07-02 12:45:27 UTC) #6

Johnni Winther

7 years, 5 months ago (2013-07-03 05:41:57 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart
(right):

https://codereview.chromium.org/18496004/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart:357: var
classNode = classElement.parseNode(compiler);
On 2013/07/02 12:16:39, karlklose wrote:
> Could we let them share common base class (the MixinApplicationElement is a
> subtype of ClassElement).

We could but the only thing used here is their [name] field.

Expand Messages | Collapse Messages