Issue 184953005: Revamp web socket API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 184953005: Revamp web socket API. (Closed)

Created:
6 years, 9 months ago by Bob Nystrom

Modified:
6 years, 9 months ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revamp web socket API. BUG=https://code.google.com/p/dart/issues/detail?id=16061 Committed: https://code.google.com/p/dart/source/detail?r=33284

Patch Set 1 #

Patch Set 2 : Revise. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1101 lines, -504 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/barback.dart	View		1 chunk	+0 lines, -63 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/build_environment.dart	View		4 chunks	+12 lines, -15 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/server.dart	View		8 chunks	+44 lines, -106 lines	0 comments	Download
A	sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart	View		1 chunk	+336 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/build.dart	View		2 chunks	+48 lines, -16 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/serve/utils.dart	View	1	9 chunks	+63 lines, -18 lines	0 comments	Download
A	sdk/lib/_internal/pub/test/serve/web_socket/asset_id_to_urls_errors_test.dart	View		1 chunk	+109 lines, -0 lines	0 comments	Download
A	sdk/lib/_internal/pub/test/serve/web_socket/asset_id_to_urls_multiple_test.dart	View		1 chunk	+54 lines, -0 lines	0 comments	Download
A	sdk/lib/_internal/pub/test/serve/web_socket/asset_id_to_urls_root_directory_test.dart	View		1 chunk	+53 lines, -0 lines	0 comments	Download
A	sdk/lib/_internal/pub/test/serve/web_socket/asset_id_to_urls_test.dart	View		1 chunk	+69 lines, -0 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/asset_id_to_urls_with_line_test.dart	View		1 chunk	+18 lines, -8 lines	0 comments	Download
A	sdk/lib/_internal/pub/test/serve/web_socket/bad_commands_test.dart	View		1 chunk	+45 lines, -0 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/converts_asset_ids_to_urls_test.dart	View		1 chunk	+0 lines, -80 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/converts_urls_to_asset_ids_test.dart	View		1 chunk	+0 lines, -71 lines	0 comments	Download
A	sdk/lib/_internal/pub/test/serve/web_socket/responds_with_id_if_given_test.dart	View		1 chunk	+52 lines, -0 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/returns_errors_on_bad_commands_test.dart	View		1 chunk	+0 lines, -55 lines	0 comments	Download
D	sdk/lib/_internal/pub/test/serve/web_socket/returns_errors_on_invalid_assets_test.dart	View		1 chunk	+0 lines, -64 lines	0 comments	Download
A	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_errors_test.dart	View		1 chunk	+77 lines, -0 lines	0 comments	Download
A	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_test.dart	View		1 chunk	+101 lines, -0 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/serve/web_socket/url_to_asset_id_with_line_test.dart	View		1 chunk	+20 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

6 years, 9 months ago (2014-03-04 18:14:14 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r33284 (presubmit successful).

Expand Messages | Collapse Messages