Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 18487005: Initial indent fix and a few more tests. (Closed)

Created:
7 years, 5 months ago by pquitslund
Modified:
7 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Initial indent fix and a few more tests. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=24825

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -53 lines) Patch
M pkg/analyzer_experimental/lib/src/services/formatter_impl.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/services/writer.dart View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/test/services/formatter_test.dart View 1 2 3 2 chunks +83 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pquitslund
7 years, 5 months ago (2013-07-08 21:30:31 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/18487005/diff/4001/pkg/analyzer_experimental/lib/src/services/writer.dart File pkg/analyzer_experimental/lib/src/services/writer.dart (right): https://codereview.chromium.org/18487005/diff/4001/pkg/analyzer_experimental/lib/src/services/writer.dart#newcode86 pkg/analyzer_experimental/lib/src/services/writer.dart:86: SourceWriter({int initialIndent: 0, this.lineSeparator: '\n'}) : Just out ...
7 years, 5 months ago (2013-07-08 21:49:11 UTC) #2
pquitslund
https://codereview.chromium.org/18487005/diff/4001/pkg/analyzer_experimental/lib/src/services/writer.dart File pkg/analyzer_experimental/lib/src/services/writer.dart (right): https://codereview.chromium.org/18487005/diff/4001/pkg/analyzer_experimental/lib/src/services/writer.dart#newcode86 pkg/analyzer_experimental/lib/src/services/writer.dart:86: SourceWriter({int initialIndent: 0, this.lineSeparator: '\n'}) : On 2013/07/08 21:49:11, ...
7 years, 5 months ago (2013-07-08 21:56:38 UTC) #3
pquitslund
7 years, 5 months ago (2013-07-08 21:59:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r24825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698