Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 184863006: [smoke] add homepage field to pubspec (Closed)

Created:
6 years, 9 months ago by Jennifer Messerly
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[smoke] add homepage field to pubspec [browser] use "author" instead of "authors" (the latter expects a list, I think) R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=33180

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/browser/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/smoke/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
apparently is required I've already uploaded this: http://pub.dartlang.org/packages/smoke
6 years, 9 months ago (2014-02-28 23:07:39 UTC) #1
Jennifer Messerly
also s/authors/author in browser
6 years, 9 months ago (2014-02-28 23:09:01 UTC) #2
Siggi Cherem (dart-lang)
lgtm
6 years, 9 months ago (2014-02-28 23:25:46 UTC) #3
Jennifer Messerly
6 years, 9 months ago (2014-02-28 23:26:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r33180 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698