- Assertions need to "touch" their conditions to avoid errors such as:

- Assertions need to "touch" their conditions to avoid errors such as:

runtime/third_party/double-conversion/src/cached-powers.cc:134:18: error: unused variable 'kCachedPowersLength' [-Werror,-Wunused-const-variable]
static const int kCachedPowersLength = ARRAY_SIZE(kCachedPowers);

Committed: https://code.google.com/p/dart/source/detail?r=33168

[Ivan Posva, 2014-02-28 18:24:12]

TBR

-Ivan

[Ivan Posva, 2014-02-28 18:24:27]

Committed patchset #1 manually as r33168.

[floitsch, 2014-02-28 18:31:48]

Please provide reproducable test-case.
I had removed this work-around, because it doesn't work on Windows (with VS'
compiler), and you didn't give me a way to reproduce even after I had asked
several times.

[floitsch, 2014-02-28 18:54:41]

and LGTM.

You will run into issues when compiling on VS, though.

[Ivan Posva, 2014-03-01 00:34:14]

On 2014/02/28 18:31:48, floitsch wrote:
> Please provide reproducable test-case.
> I had removed this work-around, because it doesn't work on Windows (with VS'
> compiler), and you didn't give me a way to reproduce even after I had asked
> several times.

- Checkout an all.deps version of the bleeding-edge Dart repository.
- setenv CC third_party/clang/linux/bin/clang
- setenv CXX third_party/clang/linux/bin/clang++
- Undo this CL
- Compile and verify that you are using clang++: ./tools/build.py --mode=all
--verbose runtime

Cheers,
-Ivan