Guard against entering a noSuchMethod dispatcher twice into ICData.

Guard against entering a noSuchMethod dispatcher twice into ICData.

This may occur in optimized code when called via the megamorphic
cache miss handler.

For now, I fixed it by checking if there is already an entry in the IC data.
I'll discuss with Kevin how to handle the extraordinary cases like
noSuchMethod and implicit closure invocation in the megamorphic cache.

BUG=https://code.google.com/p/dart/issues/detail?id=11786
R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24953

[srdjan, 2013-07-12 14:45:11]

lgtm

https://codereview.chromium.org/18469003/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/18469003/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1258: if (ic_data.num_args_tested() == 1) {
Add a TODO as discussed in the the CL text.

[Florian Schneider, 2013-07-12 15:43:59]

https://codereview.chromium.org/18469003/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/18469003/diff/1/runtime/vm/code_generator.cc#...
runtime/vm/code_generator.cc:1258: if (ic_data.num_args_tested() == 1) {
On 2013/07/12 14:45:12, srdjan wrote:
> Add a TODO as discussed in the the CL text.

Done. There is a TODO below about that.

[Florian Schneider, 2013-07-12 15:50:28]

Committed patchset #1 manually as r24953 (presubmit successful).