Add a MirrorReference reflectee for ClassMirrors. Rewrite the name accessor in terms of it, at leas…

Add a MirrorReference reflectee for ClassMirrors. Rewrite the name accessor in terms of it, at least for the non-special cases.

(This is a continuation of 18562005.)

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24826

[rmacnak, 2013-07-08 20:48:09]

Note this a new CL because I lost gcl state when switching machines.

[siva, 2013-07-08 21:29:23]

LGTM with one question/comment about passing in Dart_Null instead of intf_name.

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors.cc#newcode9
runtime/lib/mirrors.cc:9: #include "vm/dart_api_state.h"  // TODO(rmacnak):
Remove with CreateMirrorRef.
Create a new bug (issue) in https://code.google.com/p/dart/issues/list
and use the issue number in the TODO(...) above and below.

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:617: Dart_Null(),  // "name"
What is the point of not using the intf_name that is passed in and instead
setting it to Null. Is the plan to remove the intf_name parameter to
CreateClassMirror?

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:88: // implementation.
Ditto here regarding a new issue.

[rmacnak, 2013-07-08 22:01:11]

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors.cc#newcode9
runtime/lib/mirrors.cc:9: #include "vm/dart_api_state.h"  // TODO(rmacnak):
Remove with CreateMirrorRef.
On 2013/07/08 21:29:23, siva wrote:
> Create a new bug (issue) in https://code.google.com/p/dart/issues/list
> and use the issue number in the TODO(...) above and below.

Issue 11742

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors.cc#newcod...
runtime/lib/mirrors.cc:617: Dart_Null(),  // "name"
On 2013/07/08 21:29:23, siva wrote:
> What is the point of not using the intf_name that is passed in and instead
> setting it to Null. Is the plan to remove the intf_name parameter to
> CreateClassMirror?

The name parameter is still used by typedefs. The ClassMirror constructor still
takes a name because voidType and dynamicType have yet to be factored out. The
plan is to remove the entire function once ClassMirrors are instaniated on the
Dart-side.

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/18465006/diff/1/runtime/lib/mirrors_impl.dart...
runtime/lib/mirrors_impl.dart:88: // implementation.
On 2013/07/08 21:29:23, siva wrote:
> Ditto here regarding a new issue.

Issue 11743

[rmacnak, 2013-07-08 22:05:19]

Committed patchset #2 manually as r24826 (presubmit successful).