Issue 184633008: Always use the dart repo version of gsutil for the apk upload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 184633008: Always use the dart repo version of gsutil for the apk upload (Closed)

Created:
6 years, 9 months ago by ricow1

Modified:
6 years, 9 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Always use the dart repo version of gsutil for the apk upload The bot version does not support the acl setting (at least not using the current gsutil syntax) R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33381

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	tools/bots/bot_utils.py	View		1 chunk	+2 lines, -1 line	2 comments	Download
	M	tools/bots/dartium_android.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. https://codereview.chromium.org/184633008/diff/1/tools/bots/bot_utils.py File tools/bots/bot_utils.py (right): https://codereview.chromium.org/184633008/diff/1/tools/bots/bot_utils.py#newcode223 tools/bots/bot_utils.py:223: possible_locations = (list(os.environ['PATH'].split(os.pathsep)) Are you sure that we ...

6 years, 9 months ago (2014-03-06 14:49:15 UTC) #2

ricow1

Committed patchset #1 manually as r33381 (presubmit successful).

6 years, 9 months ago (2014-03-06 16:52:39 UTC) #3

ricow1

6 years, 9 months ago (2014-03-06 16:54:10 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/184633008/diff/1/tools/bots/bot_utils.py
File tools/bots/bot_utils.py (right):

https://codereview.chromium.org/184633008/diff/1/tools/bots/bot_utils.py#newc...
tools/bots/bot_utils.py:223: possible_locations =
(list(os.environ['PATH'].split(os.pathsep))
On 2014/03/06 14:49:15, Bill Hesse wrote:
> Are you sure that we want the dart_gsutil path after all the paths from $PATH?

> Are we sure this won't hit an old version?
> 
Yeah - this actually looks more complicated than necessary, lets update that in
another cl

Expand Messages | Collapse Messages