Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 18461006: Account for boolean operators shortcircuiting behavior (Closed)

Created:
7 years, 5 months ago by polux
Modified:
7 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Account for boolean operators shortcircuiting behavior R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=25211

Patch Set 1 #

Patch Set 2 : Sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart View 1 2 chunks +5 lines, -1 line 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
polux
7 years, 5 months ago (2013-07-11 15:23:55 UTC) #1
karlklose
LGTM.
7 years, 5 months ago (2013-07-17 13:44:16 UTC) #2
polux
7 years, 5 months ago (2013-07-19 13:08:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r25211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698