Issue 18442002: Add missing newline after Actual value in fail message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18442002: Add missing newline after Actual value in fail message. (Closed)

Created:
7 years, 5 months ago by gram

Modified:
7 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add missing newline after Actual value in fail message. Remove the BasMatcher class; it made some sense when we had both 'interface' and 'class' but adds no value now. Fix a comment in the CustomMatcher documentation. Fix tests affected by these changes. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=25356

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -96 lines)			Patch
M	pkg/analyzer_experimental/lib/src/generated/java_junit.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/http/test/multipart_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http/test/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/lib/src/scheduled_future_matchers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/scheduled_test/test/descriptor/file_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/lib/matcher.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/unittest/lib/mock.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
D	pkg/unittest/lib/src/basematcher.dart	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	pkg/unittest/lib/src/core_matchers.dart	View	17 chunks	+19 lines, -19 lines	0 comments	Download
M	pkg/unittest/lib/src/expect.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/lib/src/future_matchers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/lib/src/interfaces.dart	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	pkg/unittest/lib/src/iterable_matchers.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/unittest/lib/src/map_matchers.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/unittest/lib/src/numeric_matchers.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/unittest/lib/src/operator_matchers.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/unittest/lib/src/string_matchers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/unittest/test/test_utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gram

7 years, 5 months ago (2013-07-23 19:48:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r25356 (presubmit successful).

Expand Messages | Collapse Messages